Repository navigation
Typed evaluation errors with their own codes (422/424/500) - #15
Merged
Merged
Conversation
…dardized error classes, and added extensive test coverage. Updated documentation for error reporting.
…to include `data` field, revised tests, and expanded documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvaluationFunctionErrorbase class;InvalidSubmissionErrornow subclasses it, plus newUpstreamTimeoutErrorandUpstreamUnavailableError. All exported fromlf_toolkit.rpc_code) and file IO code (file_code):InvalidSubmissionError→ 422 /INVALID_SUBMISSIONUpstreamTimeoutError→ 424 /UPSTREAM_TIMEOUTUpstreamUnavailableError→ 424 /UPSTREAM_UNAVAILABLEEvaluationFunctionError→ 500 /INTERNAL_ERRORdata({"code": ...}), so the two 424s can be told apart. The message reaches the caller as-is, without the "Error calling user handler" prefix.Test plan
tests/io/(handler, rpc_handler, file_server, stream_io); 213 passed locally🤖 Generated with Claude Code