Repository navigation
ci: remove dependabot rebase workflow using personal access token - #2046
Conversation
Co-authored-by: hassieb.pakzad <hassieb.pakzad@clickhouse.com>
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: hassieb.pakzad <hassieb.pakzad@clickhouse.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 661220cf97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Additional findings (outside the current diff — GitHub can't attach inline comments there):
-
🟡
.github/workflows/dependabot-rebase-stale.yml— After merging, Dependabot PRs for both ecosystems are never rebased, so they go stale and conflict on uv.lock until someone rebases them by hand..github/dependabot.yml:14and:34still setrebase-strategy: "disabled", which relied on this workflow. Line 14's comment# use dependabot-rebase-stalenow names a deleted workflow. Fix: in this same PR, droprebase-strategy: "disabled"from bothupdatesentries in.github/dependabot.yml, along with the stale comment. Dependabot's built-in rebasing then takes over without any PAT.Why this was flagged
The deleted workflow ran on every push to
mainand rebased all open Dependabot PRs usingorange-buffalo/dependabot-auto-rebase..github/dependabot.yml:14(uv) and.github/dependabot.yml:34(github-actions) both setrebase-strategy: "disabled", and line 14's comment says that is because this workflow does the rebasing. Once both are merged, nothing rebases Dependabot PRs. Each merge to main leaves the open daily uv and github-actions PRs behind, often with uv.lock conflicts, so maintainers have to rebase or recreate them by hand. On the base branch the workflow did this on every push. The PR description calls this a known follow-up. But the fix only touches config, needs no PAT, and fits inside this change, so the regression does not have to ship.Verification: Trigger: any merge to main while uv or github-actions Dependabot PRs are open. The diff deletes
.github/workflows/dependabot-rebase-stale.yml, which rebased open Dependabot PRs on push to main..github/dependabot.ymlstill hasrebase-strategy: "disabled"on line 14 and line 34, so nothing rebases those PRs and they can conflict on uv.lock. It is a regression in automation that works on the base branch.
Refs LFE-18002.
Removes
.github/workflows/dependabot-rebase-stale.yml. On every push tomain, it rebased open Dependabot PRs viaorange-buffalo/dependabot-auto-rebase, authenticated with a personal access token stored in theDEP_REBASE_PATrepo secret.DEP_REBASE_PAThas no other users: a repo-wide grep (including all of.github/workflows/) finds no other reference.Also removes
rebase-strategy: "disabled"from.github/dependabot.ymlso Dependabot's built-in rebasing takes over. There were two such lines, under theuvecosystem (with a# use dependabot-rebase-stalecomment) and undergithub-actions. Both are removed because the deleted workflow rebased PRs from both ecosystems.After merge (Max):
DEP_REBASE_PATrepository secret.Verification:
rg -n DEP_REBASE_PATandrg -n rebase .github/both return nothing..github/dependabot.ymlstill parses as valid YAML. No code changed, so no tests were run.

Confidence Score: 5/5
The PR appears safe to merge with the acknowledged loss of automatic Dependabot rebasing.Summary
Removes
.github/workflows/dependabot-rebase-stale.yml, which usedDEP_REBASE_PATto rebase Dependabot PRs after pushes tomain.Reviews (1) · Last reviewed commit: "ci: remove dependabot rebase workflow us..." · Reviewed by Greptile