Repository navigation
feat(api): add score metadata and provenance blob export field groups - #2048
niklassemmler wants to merge 1 commit into
Conversation
Takes only the blob storage integration files from the generated API client update; the remaining spec changes ship separately. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
LGTM. This is a small Fern-generated update that adds two score export field groups and rewords the matching docstrings.
What was reviewed:
BlobStorageExportFieldGroupgainsSCORE_METADATAandSCORE_PROVENANCE, andvisit()has a dispatch branch for every member, the two new ones included.visit()now takes two more required callbacks, which is the usual Fern pattern. Nothing in the repo callsvisit()on this enum, so no internal caller breaks.- The
export_field_groupsdocstrings now say the same thing across the sync and async clients, the raw clients, the response model and the create-request model, and they match the enum docstring.
Extended reasoning...
The change touches five generated files under langfuse/api/blob_storage_integrations/: 17 lines added and 7 removed. Apart from the docstrings, the only change is two new enum values and their visit() branches. It touches no auth, crypto or data-handling code. The CODEOWNERS file only covers .github/, so none of these paths have an owner. The change is mechanical and internally consistent, and the timeline shows no reviewer objections.
What does this PR do?
Adds the
score_metadataandscore_provenancevalues toBlobStorageExportFieldGroupand updates the field-group docstrings, matching the upstream blob storage export API (langfuse/langfuse#19138).The files are taken unchanged from the generated client update in #2037. Only the blob storage integration files are included here, so the other spec changes in #2037 can ship on their own schedule.
Type of change
Verification
uv run ruff check langfuse/api/blob_storage_integrations uv run ruff format --check langfuse/api/blob_storage_integrations uv run mypy langfuse/api/blob_storage_integrations uv run python -c "from langfuse.api import BlobStorageExportFieldGroup as G; print(list(G))"Checklist
code_review.md..env.templateif needed.馃 Generated with Claude Code
Preserve existing
visit()calls before merging.Summary
Adds
score_metadataandscore_provenancetoBlobStorageExportFieldGroup.Reviews (1) 路 Last reviewed commit: "feat(api): add score metadata and proven..." 路 Reviewed by Greptile