Skip to content

feat(api): add score metadata and provenance blob export field groups - #2048

Open
niklassemmler wants to merge 1 commit into
mainfrom
feat/lfe-17855_score-export-field-groups
Open

niklassemmler wants to merge 1 commit into
mainfrom
feat/lfe-17855_score-export-field-groups

Conversation

@niklassemmler

@niklassemmler niklassemmler commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the score_metadata and score_provenance values to BlobStorageExportFieldGroup and updates the field-group docstrings, matching the upstream blob storage export API (langfuse/langfuse#19138).

The files are taken unchanged from the generated client update in #2037. Only the blob storage integration files are included here, so the other spec changes in #2037 can ship on their own schedule.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Documentation update
  • Tooling, CI, or repo maintenance

Verification

uv run ruff check langfuse/api/blob_storage_integrations
uv run ruff format --check langfuse/api/blob_storage_integrations
uv run mypy langfuse/api/blob_storage_integrations
uv run python -c "from langfuse.api import BlobStorageExportFieldGroup as G; print(list(G))"

Checklist

  • I self-reviewed the diff using code_review.md.
  • I added or updated tests for behavior changes.
  • I updated docs, examples, or .env.template if needed.
  • I did not hand-edit generated files; if generated files changed, I used the upstream regeneration path.
  • I did not commit secrets or credentials.

馃 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 4/5

Preserve existing visit() calls before merging.

Summary

Adds score_metadata and score_provenance to BlobStorageExportFieldGroup.

  • Blob storage exports can include score metadata and provenance.

Reviews (1) 路 Last reviewed commit: "feat(api): add score metadata and proven..." 路 Reviewed by Greptile

Takes only the blob storage integration files from the generated API
client update; the remaining spec changes ship separately.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a small Fern-generated update that adds two score export field groups and rewords the matching docstrings.

What was reviewed:

  • BlobStorageExportFieldGroup gains SCORE_METADATA and SCORE_PROVENANCE, and visit() has a dispatch branch for every member, the two new ones included.
  • visit() now takes two more required callbacks, which is the usual Fern pattern. Nothing in the repo calls visit() on this enum, so no internal caller breaks.
  • The export_field_groups docstrings now say the same thing across the sync and async clients, the raw clients, the response model and the create-request model, and they match the enum docstring.
Extended reasoning...

The change touches five generated files under langfuse/api/blob_storage_integrations/: 17 lines added and 7 removed. Apart from the docstrings, the only change is two new enum values and their visit() branches. It touches no auth, crypto or data-handling code. The CODEOWNERS file only covers .github/, so none of these paths have an owner. The change is mechanical and internally consistent, and the timeline shows no reviewer objections.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant