Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When an OpenAI stream yields partial output and then raises, record the generation as
ERRORwith the exception message. Keep partial output and usage, re-raise the original exception, and finalize once across native and fallback sync/async streams. Normal exhaustion, early closing, and cancellation retain their existing behavior.Fixes #2039.
Type of change
Verification
python -m pytest -p pytest_asyncio.plugin -p pytest_timeout tests/unit/test_openai.py tests/unit/test_openai_prompt_extraction.py -q --timeout=30 ruff check . ruff format --check langfuse/openai.py tests/unit/test_openai.py mypy langfuse --no-error-summary68 tests passed; Ruff and mypy passed. The SSE regression tests use the real OpenAI client with
httpx.MockTransportand an in-memory exporter. Verified with locked OpenAI 2.29.0; live-provider tests were not run.Checklist
code_review.md..env.templateif needed. (Not applicable.)

Confidence Score: 5/5
This PR appears safe to merge; no actionable issues were found.Summary
Records OpenAI stream iteration failures as
ERRORwith the exception message.No actionable issues were found. Tests were inspected but not run during this review.
Reviews (1) · Last reviewed commit: "fix(openai): record stream iteration err..." · Reviewed by Greptile