Repository navigation
Conversation
joker23
marked this pull request as ready for review
October 27, 2026 16:19
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 security issue and 1 flag
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
joker23
force-pushed
the
skz/sdk-3336/add-use-post
branch
from
October 28, 2026 15:11
913ef16 to
c7f406c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usePostoption (defaultfalse) toHttpConfigurationBuilder. When the FDv2 data system is configured, polling and streaming requests use POST with the evaluation context JSON in the request body instead of GET with the base64url context in the URL path. This keeps the context out of URL-based request logs and CDN logs.usePostis enabled, because the FDv1 endpoints do not support POST.useReportno longer affects FDv2 requests. The SDK logs one warning when it is set together with the data system. Legacy (non-data-system) FDv1 behavior is unchanged.client-use-postcapability, maps the harness'sclientSide.usePostparameter, and the v3 harness is bumped to v3.2.0-alpha.10 (the release that added the POST test variants). The bump also pulls in stricter events-redaction tests that expose a pre-existing bug inlaunchdarkly-java-sdk-internal(attribute names containing/are not escaped as attribute references inredactedAttributes). The three affected test groups are suppressed intestharness-suppressions-fdv2.txtand tracked by SDK-3338; the suppressions should be removed when that fix ships.Implements CSFDV2 Requirement 2.1.3 (usePost option) and 2.1.4 (useReport ignored with a warning under the FDv2 configuration).
Verified locally: full unit suite (752 tests) green; contract tests green on an emulator (v2 suite, and v3 at v3.2.0-alpha.10 with the suppressions above - all POST variants pass).
Note
Overview
Adds a
usePostHTTP option (default off) so that when the FDv2 data system is enabled, polling and streaming send the evaluation context in a POST body instead of a GET URL with a base64 context segment—keeping context out of URL/CDN logs. FDv2 paths that previously used REPORT underuseReportnow use POST; ETag/If-None-Matchcaching stays on GET only.With the data system,
useReportno longer changes FDv2 traffic; the builder logs a one-time warning that requests stay GET unlessusePostis on. FDv1 fallback still has no POST endpoint, so enablingusePostmaps to REPORT with a body there.Contract testing advertises
client-use-post, wires harnessclientSide.usePost, and bumps the v3 harness to v3.2.0-alpha.10. Three new v3 event-redaction cases are suppressed pending an internal SDK fix (SDK-3338).Reviewed by Cursor Bugbot for commit 913ef16. Bugbot is set up for automated code reviews on this repo. Configure here.