Skip to content

Use size_t for subsidy interval. #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Oct 28, 2026
Merged

Use size_t for subsidy interval. #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/bitcoin/database/impl/query/consensus/consensus_block.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ code CLASS::block_confirmable(const header_link& link) const NOEXCEPT

TEMPLATE
code CLASS::validate_pooled(const header_link& link, const chain_context& ctx,
uint64_t subsidy_interval, uint64_t initial_subsidy) NOEXCEPT
size_t subsidy_interval, uint64_t initial_subsidy) NOEXCEPT
{
using prevout = table::prevout;
if (!store_.pool.enabled())
Expand Down Expand Up @@ -231,7 +231,7 @@ code CLASS::check_pooled_block(pooled_block& block) const NOEXCEPT
// Block check (context) and accept: weight, coinbase, hash limit, claim, sigops.
TEMPLATE
code CLASS::accept_pooled_block(const pooled_block& block,
const chain_context& ctx, uint64_t subsidy_interval,
const chain_context& ctx, size_t subsidy_interval,
uint64_t initial_subsidy) const NOEXCEPT
{
using namespace system;
Expand Down
4 changes: 2 additions & 2 deletions include/bitcoin/database/query.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ class query
/// the block, writing its prevouts. Unvalidated implies a tx is not
/// sufficiently pooled (block requires full validation).
code validate_pooled(const header_link& link, const chain_context& ctx,
uint64_t subsidy_interval, uint64_t initial_subsidy) NOEXCEPT;
size_t subsidy_interval, uint64_t initial_subsidy) NOEXCEPT;

/// Pooled tx links by compact block short id (masked siphash of wtxid),
/// terminal where not pooled or ambiguous.
Expand Down Expand Up @@ -1167,7 +1167,7 @@ class query
const context& ctx) const NOEXCEPT;
code check_pooled_block(pooled_block& block) const NOEXCEPT;
code accept_pooled_block(const pooled_block& block,
const chain_context& ctx, uint64_t subsidy_interval,
const chain_context& ctx, size_t subsidy_interval,
uint64_t initial_subsidy) const NOEXCEPT;

/// Called by get_compact_links.
Expand Down
2 changes: 1 addition & 1 deletion test/query/consensus/consensus_block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ BOOST_AUTO_TEST_CASE(query_consensus__block_confirmable__unconfirmed_double_spen

using namespace system::chain;
constexpr auto pooled_flags = flags::bip113_rule;
constexpr uint64_t pooled_interval = 210'000;
constexpr size_t pooled_interval = 210'000;
constexpr uint64_t pooled_subsidy = 5'000'000'000;
const database::context pooled_context{ pooled_flags, 8, 9 };
const system::chain::context block_context{ pooled_flags, 0, 9, 8, 0, 0, 0 };
Expand Down
Loading