Skip to content

Validate blocks from views without materializing block objects. #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Oct 24, 2026
Merged

Validate blocks from views without materializing block objects. #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions include/bitcoin/node/chasers/chaser_validate.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class BCN_API chaser_validate
protected:
using header_link = database::header_link;
using header_links = database::header_links;
using prevout_spends = query::prevout_spends;
using signatures = system::chain::signatures;
using race = network::race_unity<const code&, const database::tx_link&>;

Expand All @@ -68,10 +69,12 @@ class BCN_API chaser_validate
virtual void validate_block(const header_link& link, bool bypass) NOEXCEPT;
virtual void scan_block(const header_link& link, bool bypass) NOEXCEPT;
virtual code validate(bool& batched, bool& capturing,
const system::chain::block& block, const header_link& link,
const system::chain::context& ctx) NOEXCEPT;
virtual code populate(const system::chain::block& block,
const system::chain::view::block& block, const prevout_spends& spends,
const database::tx_links& conflicts, const header_link& link,
const system::chain::context& ctx) NOEXCEPT;
virtual code populate(system::chain::view::block& block,
prevout_spends& spends, database::tx_links& conflicts,
const header_link& link, const system::chain::context& ctx) NOEXCEPT;
virtual code validate_view(const header_link& link, bool filter,
bool silent, bool bank) NOEXCEPT;
virtual code complete_view(const header_link& link, bool filter,
Expand Down
39 changes: 23 additions & 16 deletions src/chasers/chaser_validate_parallel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,18 +85,25 @@ void chaser_validate::validate_block(const header_link& link,
}
else
{
const auto block = query.get_block(link, node_witness_);
tx_links conflicts{};
prevout_spends spends{};
chain::view::block block
{
query.get_wire_block(link, node_witness_),
node_witness_
};

if (!block)
if (!block.is_valid())
{
ec = error::validate2;
}
else if ((ec = populate(*block, ctx)))
else if ((ec = populate(block, spends, conflicts, link, ctx)))
{
if (!query.set_block_unconfirmable(link))
ec = error::validate4;
}
else if ((ec = validate(batched, capturing, *block, link, ctx)))
else if ((ec = validate(batched, capturing, block, spends, conflicts,
link, ctx)))
{
if (!query.set_block_unconfirmable(link))
ec = error::validate5;
Expand Down Expand Up @@ -130,19 +137,18 @@ void chaser_validate::validate_block(const header_link& link,
// helpers
// ----------------------------------------------------------------------------

code chaser_validate::populate(const chain::block& block,
code chaser_validate::populate(chain::view::block& block,
prevout_spends& spends, tx_links& conflicts, const header_link& link,
const chain::context& ctx) NOEXCEPT
{
// Internal maturity and time locks are verified here because they are
// the only necessary confirmation checks for internal spends.
if (const auto ec = block.populate(ctx))
return ec;

// Metadata identifies internal spends allowing confirmation bypass.
if (!archive().populate_with_metadata(block))
// Spends identify internal spends allowing confirmation bypass.
system::data_chunk prevouts{};
if (!archive().get_block_prevouts(prevouts, spends, conflicts, link))
return system::error::missing_previous_output;

return error::success;
// Internal maturity and time locks are verified here because they are
// the only necessary confirmation checks for internal spends.
return block.populate(ctx, std::move(prevouts));
}

// Scan a validated block whose silent bank was dropped by restore.
Expand Down Expand Up @@ -247,13 +253,14 @@ code chaser_validate::complete_pooled(const header_link& link) NOEXCEPT
}

code chaser_validate::validate(bool& batched, bool& capturing,
const chain::block& block, const header_link& link,
const chain::view::block& block, const prevout_spends& spends,
const tx_links& conflicts, const header_link& link,
const chain::context& ctx) NOEXCEPT
{
auto& query = archive();

code ec{};
if (((ec = block.check(false))) || ((ec = block.check(ctx, false))))
if (((ec = block.check())) || ((ec = block.check(ctx))))
return ec;

if ((ec = block.accept(ctx, subsidy_interval_, initial_subsidy_)))
Expand Down Expand Up @@ -283,7 +290,7 @@ code chaser_validate::validate(bool& batched, bool& capturing,
return ec;

// Prevouts optimize confirmation.
if (!query.set_prevouts(link, block))
if (!query.set_prevouts(link, spends, conflicts))
return error::validate7;

if (!query.set_filter_body(link, block))
Expand Down
Loading