Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/bitcoin/node/chasers/chaser_validate.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ class BCN_API chaser_validate
// These are thread safe.
const uint32_t subsidy_interval_;
const uint64_t initial_subsidy_;
const system::chain::script signet_challenge_;
const size_t maximum_backlog_;
const size_t maximum_height_;
const uint64_t verify_target_;
Expand Down
1 change: 1 addition & 0 deletions src/chasers/chaser_validate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ chaser_validate::chaser_validate(full_node& node) NOEXCEPT
validation_strand_(validation_threadpool_.service().get_executor()),
subsidy_interval_(node.system_settings().subsidy_interval_blocks),
initial_subsidy_(node.system_settings().initial_subsidy()),
signet_challenge_(node.system_settings().signet_challenge),
maximum_backlog_(node.node_settings().maximum_concurrency_()),
maximum_height_(node.node_settings().maximum_height_()),
verify_target_(node.node_settings().batch_verify),
Expand Down
2 changes: 1 addition & 1 deletion src/chasers/chaser_validate_parallel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ code chaser_validate::validate(bool& batched, bool& capturing,
auto& query = archive();

code ec{};
if (((ec = block.check())) || ((ec = block.check(ctx))))
if (((ec = block.check())) || ((ec = block.check(ctx, signet_challenge_))))
return ec;

if ((ec = block.accept(ctx, subsidy_interval_, initial_subsidy_)))
Expand Down
8 changes: 8 additions & 0 deletions src/configuration.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ code configuration::initialize() NOEXCEPT
if (!node.use_gpu_())
database.gpu_scan_minimum = max_uint32;

// The signet message identifier is derived from its challenge [bip325].
if (bitcoin.forks.signet)
{
const auto challenge = bitcoin.signet_challenge.to_data(true);
const auto hash = system::bitcoin_hash(challenge);
network.identifier = system::from_little_endian<uint32_t>(hash);
}

database.initialize(bitcoin, node.limited_blocks, node.silent_start_height);
return network.initialize();
}
Expand Down
15 changes: 15 additions & 0 deletions test/configuration.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,21 @@ BOOST_AUTO_TEST_CASE(configuration__initialize__mainnet__success_peer_identifier
BOOST_REQUIRE_EQUAL(instance.network.peer.identifier, 0xd9b4bef9_u32);
}

BOOST_AUTO_TEST_CASE(configuration__initialize__signet__success_peer_identifier_signet_magic)
{
node::configuration instance(chain::selection::signet);
BOOST_REQUIRE(!instance.initialize());
BOOST_REQUIRE_EQUAL(instance.network.peer.identifier, 0x40cf030a_u32);
}

BOOST_AUTO_TEST_CASE(configuration__initialize__custom_signet__success_peer_identifier_challenge_magic)
{
node::configuration instance(chain::selection::signet);
instance.bitcoin.signet_challenge = system::config::script{ "1" };
BOOST_REQUIRE(!instance.initialize());
BOOST_REQUIRE_EQUAL(instance.network.peer.identifier, from_little_endian<uint32_t>(bitcoin_hash(base16_chunk("0151"))));
}

BOOST_AUTO_TEST_CASE(configuration__initialize__silent_without_witness__silent_unwitnessed)
{
node::configuration instance(chain::selection::mainnet);
Expand Down
Loading