[good first issue] Add PaymentKind::payment_hash as an accessor method #730

Activity

1. jgmcalpine commented on Dec 29, 2025

   

   jgmcalpine

   on Dec 29, 2025

   Contributor

   More actions

   Hi! I would like to work on this issue, I am setting up my environment and will submit a PR shortly.
2. jgmcalpine commented on Dec 29, 2025

   

   jgmcalpine

   on Dec 29, 2025

   Contributor

   More actions

   I've implemented the accessor methods and opened a PR for review here: #734
3. tnull commented on Jan 5, 2026

   

   tnull

   on Jan 5, 2026

   Collaborator

   More actions

   I'm a bit on the fence regarding adding Lightning-specific accessor APIs for PaymentKind which is explicitly an umbrella type also covering other payment methods that don't feature payment hashes/secrets/pre-images.
4. TheBlueMatt commented on Jan 5, 2026

   

   TheBlueMatt

   on Jan 5, 2026

   Contributor

   More actions

   Just annoying to have to match every time you want to extract stuff, but doesn't really matter that much, if you think its gross, close.
5. tnull commented on Jan 8, 2026

   

   tnull

   on Jan 8, 2026

   Collaborator

   More actions

   Just annoying to have to match every time you want to extract stuff, but doesn't really matter that much, if you think its gross, close.

   Yeah, still not convinced we should do this, and in #734 it turned out that we can't even easily expose it in bindings due to PaymentKind being an enum interface, disallowing to expose further methods. So, for the time being, I'll close this as wontfix. Maybe if uniffi changes some of the requirements we can revisit this if we still think the sugar would be worth it.
6. tnull

   closed this as not plannedon Jan 8, 2026