[tnull]

Closes #654
Closes #1055

We bump bdk_wallet dependency, migrate to the updated signing API, and finally add some regression tests for the Electrum EOF fix that shipped in electrum-client.

[ldk-reviews-bot]

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[tankyleo]

I also note that we currently include unconfirmed outputs from TRUC transactions in BalanceDetails::spendable_onchain_balance_sats, even though our onchain wallet currently never spends them. I think this is OK since we don't expect our onchain funds to be transaction outputs of V3 transactions.

[tnull]

Let me know if I can squash

[tankyleo]

Thanks yes please squash, this diff can help reduce flakiness in the clean_eof_wakes_concurrent_electrum_requests test.

diff --git a/src/chain/electrum.rs b/src/chain/electrum.rs
index 24b9b1a9..00155771 100644
--- a/src/chain/electrum.rs
+++ b/src/chain/electrum.rs
@@ -971,7 +971,7 @@ mod tests {
                        // unblock it until every request was fully written and flushed (excluding the
                        // version handshake).
                        let nudge = serde_json::json!({"jsonrpc": "2.0", "method": "test.nudge", "params": []});
-                       let deadline = std::time::Instant::now() + Duration::from_secs(10);
+                       let deadline = std::time::Instant::now() + Duration::from_secs(30);
                        while client.calls_made().unwrap() - 1 < REQUEST_COUNT {
                                assert!(std::time::Instant::now() < deadline, "requests weren't all sent");
                                writeln!(reader.get_mut(), "{nudge}").unwrap();
@@ -1016,7 +1016,7 @@ mod tests {

                for _ in 0..REQUEST_COUNT {
                        let failed_as_expected = finished_receiver
-                               .recv_timeout(Duration::from_secs(5))
+                               .recv_timeout(Duration::from_secs(60))
                                .expect("clean EOF must wake every concurrent Electrum request");
                        assert!(failed_as_expected);
                }

[tnull]

Thanks yes please squash, this diff can help reduce flakiness in the clean_eof_wakes_concurrent_electrum_requests test.

diff --git a/src/chain/electrum.rs b/src/chain/electrum.rs
index 24b9b1a9..00155771 100644
--- a/src/chain/electrum.rs
+++ b/src/chain/electrum.rs
@@ -971,7 +971,7 @@ mod tests {
                        // unblock it until every request was fully written and flushed (excluding the
                        // version handshake).
                        let nudge = serde_json::json!({"jsonrpc": "2.0", "method": "test.nudge", "params": []});
-                       let deadline = std::time::Instant::now() + Duration::from_secs(10);
+                       let deadline = std::time::Instant::now() + Duration::from_secs(30);
                        while client.calls_made().unwrap() - 1 < REQUEST_COUNT {
                                assert!(std::time::Instant::now() < deadline, "requests weren't all sent");
                                writeln!(reader.get_mut(), "{nudge}").unwrap();
@@ -1016,7 +1016,7 @@ mod tests {

                for _ in 0..REQUEST_COUNT {
                        let failed_as_expected = finished_receiver
-                               .recv_timeout(Duration::from_secs(5))
+                               .recv_timeout(Duration::from_secs(60))
                                .expect("clean EOF must wake every concurrent Electrum request");
                        assert!(failed_as_expected);
                }

Squashed and included.