Repository navigation
TPT-4651: Add integration tests for Premium NodeBalancer changes - #933
Open
psnoch-akamai wants to merge 2 commits into
Open
psnoch-akamai wants to merge 2 commits into
psnoch-akamai wants to merge 2 commits into
Conversation
psnoch-akamai
requested review from
jcamelon and
mawilk90
and
a balanced review from Copilot
and removed request for
a team
October 15, 2026 15:40
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fixture setup failures can leak VPC resources, and help assertions can pass despite missing options.
2 open findings
What changed in this PR
Adds integration coverage for Premium NodeBalancers with VPC backends.
Changes:
- Tests list columns, create/view/update output, and create-command help.
- Adds a Premium NodeBalancer fixture with VPC resources.
- Introduces a shared help-parameter assertion helper.
| File | Description |
|---|---|
| tests/integration/nodebalancers/test_node_balancers.py | Adds Premium NodeBalancer and CLI output tests. |
| tests/integration/nodebalancers/fixtures.py | Provisions a VPC-backed Premium NodeBalancer. |
| tests/integration/helpers.py | Adds help-parameter assertions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| def assert_help_parameters_list_for_command(expected_parameters, help_output): | ||
| for expected_parameter in expected_parameters: | ||
| re.search( |
Contributor
There was a problem hiding this comment.
Agree, it will never fail without assert
Comment on lines
+374
to
+376
| test_region = get_random_region_with_caps( | ||
| ["NodeBalancers", "Premium NodeBalancers"] | ||
| ) |
Contributor
There was a problem hiding this comment.
Agree, it will probably fail on Prod
psnoch-akamai
requested review from
ezilber-akamai,
jriddle-linode,
lgarber-akamai,
yec-akamai and
zliang-akamai
and removed request for
jcamelon
October 19, 2026 13:53
mawilk90
reviewed
Oct 20, 2026
| nodebalancer_with_reserved_ipv4, | ||
| nodebalancer_with_udp_config_and_node, | ||
| simple_nodebalancer_with_config, | ||
| vpc_for_nodebalancer_type_premium_backend_connectivity_vpc, |
Contributor
There was a problem hiding this comment.
It seems to be never used in this file
mawilk90
reviewed
Oct 20, 2026
| test_vpc_id = exec_test_command( | ||
| [ | ||
| "linode-cli", | ||
| "vpcs", |
mawilk90
reviewed
Oct 20, 2026
|
|
||
|
|
||
| @pytest.fixture | ||
| def nodebalancer_type_premium_backend_connectivity_vpc( |
Contributor
There was a problem hiding this comment.
IMO, this name is a bit redundant. What do you think to make it simpler, e.g. nodebalancer_premium_with_backend_vpc ?
mawilk90
reviewed
Oct 20, 2026
|
|
||
|
|
||
| @pytest.fixture | ||
| def vpc_for_nodebalancer_type_premium_backend_connectivity_vpc(): |
Contributor
There was a problem hiding this comment.
+1. What do you think about: vpc_for_nb_premium_backend_connectivity ?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✔️ How to Test
make test-int TEST_CASE=test_verify_columns_for_list_nodebalancersmake test-int TEST_CASE=test_premium_nodebalancer_with_vpc_backend_connectivitymake test-int TEST_CASE=test_create_nodebalancer_help_commandTo run tests verify required configuration described at JIRA epic ticket.