Repository navigation
fix: stop re-enabling the package downloads widget on integration changes - #5173
Conversation
…nges Refs linuxfoundation/lfx-cdp-insights-ops#976 Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
PR SummaryLow Risk Overview A one-time migration Reviewed by Cursor Bugbot for commit 4fa960a. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Package downloads widget default and migration changes.
No open issues 🎉
What changed in this PR
Prevents integration changes from restoring the disabled Package downloads widget in Insights projects and removes existing instances.
Changes:
- Disable
PACKAGE_DOWNLOADSin shared widget defaults while preserving manual enablement. - Add a migration to remove
packageDownloadsfrom affected projects and update their modification timestamps.
| File | Description |
|---|---|
services/libs/types/src/enums/widgets.ts |
Disables Package downloads by default. |
backend/src/database/migrations/V1793641911__removePackageDownloadsWidget.sql |
Removes the widget from existing project configurations. |
Review effort: Balanced
[Medium impact] The PR appears safe to merge, with the previous finding fully addressed. SummaryDisables
Reviews (2) · Last reviewed commit: "fix: drop the redundant comment from the..." · Reviewed by Greptile |
Refs linuxfoundation/lfx-cdp-insights-ops#976 Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Summary
The Package downloads widget was turned off for every Insights project, but it kept coming back. 1,107 projects in prod have it again.
DEFAULT_WIDGET_VALUESstill enabled it for GitHub and GitHub Nango. Every integration create, update, delete or GitHub Nango connect rebuilds a project's widgets from those defaults, so any project with GitHub got the widget back.Changes
PACKAGE_DOWNLOADStoenabled: falseinDEFAULT_WIDGET_VALUES. Integration changes no longer add it, and the admin "add project" form no longer ticks it when it loads a segment's widgets. Admins can still turn it on by hand.packageDownloadsfrom everyinsightsProjectsrow that has it.Type of change
Related issue
Closes linuxfoundation/lfx-cdp-insights-ops#976