Repository navigation
Check each branch of a conditional expression under its condition - #409
Open
CatarinaGamboa wants to merge 1 commit into
Open
CatarinaGamboa wants to merge 1 commit into
CatarinaGamboa wants to merge 1 commit into
Conversation
The branches of `c ? a : b` were checked without knowing which way c went, so `canUndo ? um.getUndoPresentationName() : "Undo"` was rejected even though the call only runs when canUndo holds. Each branch now gets the condition (or its negation) as a path condition, encoded as for loops. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rcosta358
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The branches of a conditional expression were checked without knowing which way its condition went:
The same guard written as an
ifpasses.visitCtConditionalscanned the condition and both branches with no path condition, then only built the ITE for the expression's value.Fix
visitCtConditionalscans the condition, then each branch with the condition (then) or its negation (else) as a path condition, removed after the branch.assumeLoopCondition), nowassumeCondition(condition, holds); loops call it withtrue. Conditions with side effects still assume nothing.Tests
CorrectTernaryConditionInBranch:full ? box.peek() : 0wherepeekneedsfull(this)andfullisbox.isFull(). It failed before this change.ErrorTernaryConditionInBranch:full ? 0 : box.peek(): still reported.mvn test: 429 tests, 0 failures.Found on a real fixed bug (JabRef's
CountingUndoManager, which labels its undo and redo events withcanUndo ? getUndoPresentationName() : ...). We also checked 53 exercises built from real OSS bugs on main (e0a6c81) and with this change: the results are identical.🤖 Generated with Claude Code