Skip to content

test(lk): allow the project fallback only for an unconfigured livekit.toml #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Topherhindman merged 1 commit into from
Oct 29, 2026
Merged

test(lk): allow the project fallback only for an unconfigured livekit.toml #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions cmd/lk/credential_property_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,14 @@ func TestCredentialResolution(t *testing.T) {
strings.Join(c.env(), " "), strings.Join(c.args(), " "), conf, strings.Join(requests, "\n"), output)

allowed := c.namedProjects()
if sole := c.soleProject(); !c.userAuth && c.command.fallback && sole != "" {
// Known bug: when resolving what the user named fails, room list
// falls back to the only configured project (mistyped-project.txtar).
_, key, secret := c.inlineCredentials()
tomlUnresolved := !c.dev && (key == "" || secret == "") && c.toml != "" && !c.configured(c.toml)
if sole := c.soleProject(); !c.userAuth && c.command.fallback && sole != "" &&
c.project == "" && c.subdomain == "" && tomlUnresolved {
// With no project named on the command line, room list falls back
// to the only configured project when resolving fails. lk keeps
// that on purpose for a livekit.toml naming a project that isn't
// configured, so an agent repo still gets a project to choose.
allowed = append(allowed, sole)
}
named := false
Expand Down Expand Up @@ -266,8 +271,9 @@ type credentialCase struct {
type credentialCommand struct {
args []string
// fallback is set when, in API-key mode, a failure to resolve a project
// falls back to the only configured one (requireProjectWithOpts);
// loadProjectDetails fails instead.
// that --project, --subdomain or --dev didn't ask for falls back to the
// only configured one (requireProjectWithOpts); loadProjectDetails fails
// instead.
fallback bool
// publicAPI is set for a command that calls the Public API directly with
// the session (and only runs under --user-auth), instead of using a
Expand Down
Loading