Repository navigation
fix(rtc-node): send the required key and track SID in E2EE requests - #768
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 593b012 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first two defects in #741.
Three E2EE wrappers build FFI requests that leave out a
requiredproto2 field, so encoding the request throws (cannot encode field ... required field not set) and the call can never reach the native side:KeyProvider.setKey(participantIdentity, keyIndex)has no way to pass the key, andSetKeyRequest.keyis required. It now takes the key, matching the Python SDK'sset_key(participant_identity, key, key_index):setKey(participantIdentity, key, keyIndex). The old signature could not work, so no working caller is affected.FrameCryptor.setEnabled()andFrameCryptor.setKeyIndex()don't sendtrack_sid, whichFrameCryptorSetEnabledRequestandFrameCryptorSetKeyIndexRequestboth require.FrameCryptornow stores the track SID (as the PythonFrameCryptordoes), andE2EEManager.frameCryptors()passes in thetrackSidthe FFI already returns.The third point in #741 turned out to be on the reporter's side (see their follow-up comment), so it is not part of this PR.
Tests
src/e2ee.test.tsspies onFfiClient.request, encodes each captured request withFfiRequest.toBinary(), and checks thatframeCryptors()keeps the track SID. All three tests fail onmainand pass with this change. A patch changeset is included.