Repository navigation
Add Windows ARM64 wheels - #840
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| - os: windows-11-arm | ||
| archs: ARM64 |
There was a problem hiding this comment.
🔴 Windows ARM64 wheel jobs select no builds
On Windows ARM64, CIBW_ARCHS=ARM64 combines with the cp39-* build selector, leaving cibuildwheel no eligible builds. Windows ARM64 builds start at CPython 3.11, so both wheel jobs fail and prevent publication.
Learn more
Both the RTC workflow and the release workflow add an ARM64 runner and pass ARM64 to cibuildwheel. The package's build selector only allows cp39-*, while cibuildwheel's native Windows ARM64 Python builds start at 3.11. As a result, selecting the ARM64 architecture leaves no build identifiers; the job cannot upload a wheel. The same selection occurs in the release build.
Example: An RTC tag starts the windows-11-arm job. It requests cp39-* on ARM64, finds no native CPython 3.9 ARM64 build, and never uploads rtc-release-windows-11-arm; the dependent test and publish jobs cannot complete.
Recommended fix: Extend the cibuildwheel build selector to include a supported Windows ARM64 version, such as cp311-win_arm64, while retaining the existing cp39-* builds. Verify the resulting wheel artifact and tests on the ARM64 runner in both workflows.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
cibuildwheel has Python 3.9 releases for Windows ARM64 available to it via NuGet. As evidenced by the passing CI job.
|
@copilot resolve the merge conflicts in this pull request |
|
👋 This PR has no changeset. If it should be released, add a markdown file under ---
"livekit-rtc": patch
---
Short description of the change, used in the release notes.
If this change doesn't need a release (docs, CI, tests), you can ignore this comment. |
|
Copilot didn't want to fix the conflicts so I did that myself, @cloudwebrtc could you take another look? Thanks! |
|
Thanks for merging! Do you have a timeline for the next release? |
As the title says -- all tests are passing on my fork. Along the way I noticed some warnings in the tests, which were trivial to fix, so I added those fixes as well -- let me know if that's fine.