Repository navigation
Export the state in the shutdown hook with Python instead of curl - #4
Merged
Merged
Conversation
The hook runs inside the LocalStack container, and the LocalStack image no longer ships curl since 2026.10.0, so no pod was exported on shutdown and CI failed at `ls -l volume/my-pod.zip`. Use the image's Python instead. Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker compose job fails on
mainsince LocalStack 2026.10.0 (run) at "Stop LocalStack and check the shutdown hook exported the state":on-shutdown-hooks/save-pod.shruns inside the LocalStack container and calledcurl, which the LocalStack image no longer ships, so the hook exported nothing. It now downloads/_localstack/pods/statewith the image's Python (no proxy, same as the image's own healthcheck). Thecurlcalls intest.shand the workflow run on the runner and are unchanged.Tested locally with
localstack/localstack-pro:latest(2026.10.0), following the docker compose job:docker compose up -d,./test.shpasses,docker compose downwritesvolume/my-pod.zip(with the Secrets Manager state), andlstk loadinto a fresh LocalStack returns the secret.