Skip to content

fix(workspace): preserve focus moved after closing task details #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopx-agent merged 2 commits into from
Nov 1, 2026
Merged

fix(workspace): preserve focus moved after closing task details #7807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae6fc2
fix(workspace): preserve focus moved after closing task details
loopx-agent Nov 1, 2026
9610afb
test(workspace): bind work-map reads to the selected package
loopx-agent Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/presentation/dashboard/src/features/personal-workspace/context-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ export function ContextDrawer({ agents, attentionHistory = [], onSelectAttention
const returnFocus = returnFocusRef.current;
onClose();
window.requestAnimationFrame(() => {
const activeElement = document.activeElement;
if (activeElement instanceof HTMLElement && activeElement !== document.body
&& !drawerRef.current?.contains(activeElement)) return;
if (returnFocus && returnFocus !== document.body) {
returnFocus.focus();
if (document.activeElement === returnFocus) return;
Expand Down
17 changes: 13 additions & 4 deletions examples/personal-workspace-browser/goal-work-map.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ import { spawn } from "node:child_process";
import { mkdtemp, rename, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import { createInterface } from "node:readline";
import { resolveTestPython } from "../../scripts/test-python.mjs";
import { testPythonCommand } from "../../scripts/test-python.mjs";
import { outputDir, repoRoot } from "./fixture.mjs";
import { deliveryReadFixture } from "./showcase-workspace.mjs";
import { fetchWorkspaceBackend, openWorkspacePage } from "./scenario-context.mjs";

async function requestAuthority(text) {
const root = await mkdtemp(resolve(tmpdir(), "loopx-map-request-"));
const child = spawn(resolveTestPython(), ["-u", "-c", `
const python = testPythonCommand(`
from pathlib import Path
import json, os, signal, sys, tempfile
root = Path(sys.argv[1]); tempfile.tempdir = str(root)
Expand Down Expand Up @@ -41,7 +41,8 @@ finally:
server.server_close()
assert read_canonical_todos_if_promoted(runtime_root=runtime, goal_id="product-release") == before
restart_effect_runtime()
`, root, text], { cwd: repoRoot, stdio: ["ignore", "pipe", "pipe"] });
`);
const child = spawn(python.command, [...python.args, root, text], { cwd: repoRoot, stdio: ["ignore", "pipe", "pipe"] });
const lines = createInterface({ input: child.stdout });
let diagnostic = "";
child.stderr.on("data", chunk => { diagnostic = (diagnostic + chunk).slice(-3000); });
Expand Down Expand Up @@ -203,7 +204,15 @@ export const goalWorkMapScenario = {
await rename(hiddenRegistry, authority.registry);
await drawer.getByRole("button", { name: "重试读取完整要求", exact: true }).click();
await drawer.getByText(finalRequirement, { exact: true }).waitFor();
await page.getByRole("button", { name: /关闭详情/ }).click();
await page.getByRole("button", { name: /关闭详情/ }).evaluate(button => {
button.click();
document.querySelector(".goal-overview-evidence > summary")?.focus();
});
await page.evaluate(() => new Promise(resolve => requestAnimationFrame(resolve)));
assert.equal(await page.locator(".goal-overview-evidence > summary").evaluate(
summary => document.activeElement === summary), true,
"Closing Task details must preserve focus explicitly moved to another control");
await page.screenshot({ path: resolve(outputDir, "goal-map-focus-return-desktop.png"), animations: "disabled" });

limits = { omitted_node_count: 3, topology_complete: false };
const evidence = page.locator(".goal-overview-evidence");
Expand Down
Loading