Skip to content

refactor(cli): keep Codex host binding in the existing adapter owner #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopx-agent merged 1 commit into from
Nov 1, 2026
Merged

refactor(cli): keep Codex host binding in the existing adapter owner #7809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions loopx/cli_commands/turn_host_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
from pathlib import Path
from typing import Any, cast

from ..control_plane.goals.first_party_host_admission import FirstPartyHostGoalAdmission


def prepare_turn_host_request(
args: argparse.Namespace, payload: Mapping[str, Any], *,
Expand Down Expand Up @@ -74,3 +76,54 @@ def prepare_turn_host_request(
else {}
)
return project, raw_argv, task_validator, envelope


def build_codex_cli_host_runner(
args: argparse.Namespace, *, runtime_root: Path, project: Path,
registry_path: Path, goal_ref: Mapping[str, object] | None,
goal_admission: FirstPartyHostGoalAdmission | None,
current_launch_decision: Callable[[Path], Mapping[str, Any]],
run_codex_cli_host: Callable[..., dict[str, Any]],
) -> Callable[[Mapping[str, Any]], dict[str, Any]]:
"""Bind the existing Codex adapter; resolve options/admission only at launch."""
def run_built_in_host(
request: Mapping[str, Any],
) -> dict[str, Any]:
options = {
"runtime_root": runtime_root,
"project": project,
"codex_bin": args.codex_bin,
"sandbox": args.codex_sandbox,
"model": args.codex_model,
"reasoning_effort": args.codex_reasoning_effort,
"mcp_server": args.codex_mcp_server_json,
"timeout_seconds": None if args.timeout_seconds is None else max(1.0, args.timeout_seconds - 5.0),
}
options["goal_admission"] = (
goal_admission or FirstPartyHostGoalAdmission.for_plan(
registry_path=registry_path, goal_id=args.goal_id,
planned_goal_ref=goal_ref,
)
).with_launch_decision(current_launch_decision)
if getattr(args, "codex_operation_tools", False):
from ..control_plane.turn_driver.codex_operation_host import (
run_codex_operation_host,
)

return run_codex_operation_host(
request,
registry_path=registry_path,
confirmed_operation_id=getattr(
args, "codex_confirmed_operation_id", None
),
source_route=getattr(
args, "codex_operation_source_route_json", None
),
operation_request_file=(Path(args.operation_request_file)
if getattr(args, "operation_request_file", None) else None),
operation_request_sha256=getattr(args, "operation_request_sha256", None),
**options,
)
return run_codex_cli_host(request, registry_path=registry_path, **options)

return run_built_in_host
50 changes: 8 additions & 42 deletions loopx/cli_commands/turn_run_once.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
from ..state_refresh import refresh_state_run
from ..control_plane.todos.path_resolution import resolve_todo_state_path
from .turn_cadence import managed_cadence_start
from .turn_host_request import prepare_turn_host_request
from .turn_host_request import build_codex_cli_host_runner, prepare_turn_host_request
from .turn_decision import collect_turn_status_payload, current_turn_host_launch_decision
from .turn_dsh_host import build_dsh_host_runner, build_dsh_operation_host_runner
from .turn_rendering import build_turn_error_payload
Expand Down Expand Up @@ -835,47 +835,13 @@ def current_launch_decision(current_registry: Path) -> Mapping[str, Any]:
goal_ref=goal_ref,
)

def run_built_in_host(
request: Mapping[str, Any],
) -> dict[str, Any]:
options = {
"runtime_root": runtime_root,
"project": project,
"codex_bin": args.codex_bin,
"sandbox": args.codex_sandbox,
"model": args.codex_model,
"reasoning_effort": args.codex_reasoning_effort,
"mcp_server": args.codex_mcp_server_json,
"timeout_seconds": None if args.timeout_seconds is None else max(1.0, args.timeout_seconds - 5.0),
}
options["goal_admission"] = (
goal_admission or FirstPartyHostGoalAdmission.for_plan(
registry_path=registry_path, goal_id=args.goal_id,
planned_goal_ref=goal_ref,
)
).with_launch_decision(current_launch_decision)
if getattr(args, "codex_operation_tools", False):
from ..control_plane.turn_driver.codex_operation_host import (
run_codex_operation_host,
)

return run_codex_operation_host(
request,
registry_path=registry_path,
confirmed_operation_id=getattr(
args, "codex_confirmed_operation_id", None
),
source_route=getattr(
args, "codex_operation_source_route_json", None
),
operation_request_file=(Path(args.operation_request_file)
if getattr(args, "operation_request_file", None) else None),
operation_request_sha256=getattr(args, "operation_request_sha256", None),
**options,
)
return run_codex_cli_host(request, registry_path=registry_path, **options)

host_runner = run_built_in_host
host_runner = build_codex_cli_host_runner(
args, runtime_root=runtime_root, project=project,
registry_path=registry_path, goal_ref=goal_ref,
goal_admission=goal_admission,
current_launch_decision=current_launch_decision,
run_codex_cli_host=run_codex_cli_host,
)

def resolve_built_in_session_binding(
turn_envelope: Mapping[str, Any],
Expand Down
Loading