Repository navigation
reject an empty entry in the -u list - #377
Merged
Merged
Conversation
an empty entry like the first one in "-u ,99999", or a lone "^", was parsed as UID 0, so lsof listed or excluded root's files. report an error instead.
jiegec
reviewed
Nov 3, 2026
| } | ||
| } | ||
| } | ||
| return (err); |
Member
There was a problem hiding this comment.
Maybe check if empty list here? For e.g. -u "".
Contributor
Author
There was a problem hiding this comment.
good catch, -u "" was just listing everything. it now errors out with "no UIDs specified" like a missing argument, and added it to the test
-u "" was accepted with no UIDs at all, so lsof just listed evrything, root's files included. treat it like a missing argument and report "no UIDs specified".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsof -u ,99999lists root's files:the empty first entry goes through
enter_uid()with nothing parsed, so the uid stays 0. a lone-u ^excludes root the same way. easy to hit from a script that builds the list with a leading comma.added
case-20-uid-empty-entry.bashfor both forms, it fails before and passes after.make checkis clean.