Repository navigation
Reject NULL contexts in liblsof API (#378) - #381
Open
hugojosealmeida wants to merge 2 commits into
Open
hugojosealmeida wants to merge 2 commits into
hugojosealmeida wants to merge 2 commits into
Conversation
jiegec
reviewed
Nov 3, 2026
| * If the context is not frozen, lsof_freeze() will be called. | ||
| * | ||
| * \return LSOF_INVALID_ARGUMENT if either pointer argument is NULL | ||
| * \return LSOF_ERROR_INVALID_ARGUMENT if either pointer argument is NULL |
Member
There was a problem hiding this comment.
Add this annotation to other functions?
Contributor
Author
There was a problem hiding this comment.
LSOF_INVALID_ARGUMENT is not used by any function and is not defined. It was only a typo in this one documentation comment.
Member
There was a problem hiding this comment.
I mean, other functions could have \return annotations like this as well.
hugojosealmeida
force-pushed
the
sdlc/issue-378-reject-null-contexts
branch
from
November 3, 2026 07:29
e13301a to
d47d9d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject NULL contexts before dereferencing them in liblsof API entry points.
Changes
Verification
This PR is AI Assisted.
Closes #378