You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Free file metadata discarded by successful gathers (#379) - #382
I have reproduced on Darwin: three filtered gathers reported 84 leaks / 7,632 bytes. With the fix, that dropped to 3 leaks / 4,128 bytes; the allocation stacks for nm, fsdir, and fsdev disappeared.
The remaining leaks seems to be Darwin gather buffers outside this fix. I have added a test that also confirms that selected names survive context destruction and the filtered FD is not returned.
The new test requires an exact pathname match and so maybe the failure is likely a portability issue in the test I added: the existing LTbasic2 explicitly calls stat() after file creation to make FreeBSD expose the pathname. I will investigate.
Found it, the test assumes name is a raw pathname, but FreeBSD appends filesystem information. Its exact strcmp()therefore rejects a valid result. The fix on the test changes that comparison tostrstr()` (and adds a comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Free file metadata discarded by successful lsof_gather calls while preserving transferred result names.
Changes
Verification
This PR is AI Assisted.
Closes #379