feat: Binned Spline Maker valdiations

CIValidations/CMakeLists.txt

@@ -1,6 +1,7 @@
 add_custom_target(ValidApps)
 
 foreach(app
+    SplineMaker
     SplineValidations
     FitterValidations
     CovarianceValidations

CIValidations/MaCh3CLI

@@ -34,6 +34,7 @@ show_help() {
 # Run validation functions
 run_reweight_validations() {
   ${MaCh3Tutorial_ROOT}/CIValidations/SplineValidations
+  ${MaCh3Tutorial_ROOT}/CIValidations/SplineMaker
   ${MaCh3Tutorial_ROOT}/CIValidations/SamplePDFValidations
   ${MaCh3Tutorial_ROOT}/CIValidations/LLHValidation
   ${MaCh3Tutorial_ROOT}/bin/KinemDistributionTutorial ${MaCh3Tutorial_ROOT}/TutorialConfigs/FitterConfig.yaml

CIValidations/README.md

@@ -49,8 +49,8 @@
 ## BinningValidations
 * Checks if event migration works as intended
 
-### TODO
-* add test with different interpolations
+## SplineMaker
+* Generates binned splines and ensure they are same as stored
 
 ## SamplePDFValidations
 * Dump and compare event weights

CIValidations/SplineMaker.cpp

@@ -0,0 +1,68 @@
+#include "SplinesTutorial/BinnedSplineMakerTutorial.h"
+#include "Utils/Comparison.h"
+
+void ValidateSplines(std::ostream& outFile){
+  std::string TutorialPath = std::getenv("MaCh3Tutorial_ROOT");
+  const std::string rootPath = TutorialPath + "/SplineTutorialTest.root";
+
+  TFile rootFile(rootPath.c_str(), "READ");
+  if (rootFile.IsZombie()) {
+    MACH3LOG_CRITICAL("Could not open ROOT file: {}", rootPath);
+    throw MaCh3Exception(__FILE__, __LINE__);
+  }
+
+  TIter next(rootFile.GetListOfKeys());
+  while (TKey *key = static_cast<TKey *>(next())) {
+    TObject *object = key->ReadObj();
+
+    auto *spline = dynamic_cast<TSpline3 *>(object);
+    if (spline == nullptr) {
+      delete object;
+      continue;
+    }
+
+    outFile << "Spline: " << spline->GetName() << '\n';
+
+    const int nKnots = spline->GetNp();
+    for (int i = 0; i < nKnots; ++i) {
+      double x = 0.0;
+      double y = 0.0;
+
+      spline->GetKnot(i, x, y);
+      outFile << "Knot: " << i << ", x: " << x << ", y: " << y << '\n';
+    }
+
+    outFile << '\n';
+    delete object;
+  }
+  rootFile.Close();
+}
+
+
+int main(int argc, char *argv[]) {
+  if (argc != 1) {
+    MACH3LOG_CRITICAL("You specified arguments, but none are needed. (Program name: {})", argv[0]);
+    throw MaCh3Exception(__FILE__ , __LINE__ );
+  }
+  M3::rand::SetSeed(666);
+
+  const std::string Config = std::string(std::getenv("MaCh3Tutorial_ROOT")) + "/TutorialConfigs/Spline/SplineTutorial.yaml";
+  auto SplineMaker = std::make_unique<BinnedSplineMakerTutorial>(Config);
+
+  SplineMaker->MakeVariations();
+
+  std::ofstream outFile("NewSplineMakerOut.txt");
+  std::string TutorialPath = std::getenv("MaCh3Tutorial_ROOT");
+  ValidateSplines(outFile);
+  outFile.close();
+
+  bool TheSame = CompareTwoFiles(TutorialPath + + "/CIValidations/TestOutputs/SplineMakerOut.txt", "NewSplineMakerOut.txt");
+  if(!TheSame) {
+    MACH3LOG_CRITICAL("Different likelihood mate");
+    throw MaCh3Exception(__FILE__ , __LINE__ );
+  } else {
+    MACH3LOG_INFO("Everything is correct");
+  }
+
+  return 0;
+}