Repository navigation
Raise on unknown browsers in targets - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates
targetsto raise aLightningCSS::OptionErrorfor a browser name it doesn't know, instead of ignoring it.A misspelled browser, like
safar: 15, used to be skipped without a word, so the stylesheet was compiled as if that target wasn't there. That's the same problemLightningCSS::Optionsalready refuses an unknown option for.The names are checked before any version is read, and listed in order, so the message doesn't depend on hash order.
iosstill reads asios_saf.This raises for code that passed an extra key in
targets, which used to do nothing.