Skip to content

Move nogil to end of function signatures - #193

Merged
matham merged 3 commits into
matham:masterfrom
cclauss:move-nogil-to-end-of-function-signatures
Oct 31, 2026
Merged

matham merged 3 commits into
matham:masterfrom
cclauss:move-nogil-to-end-of-function-signatures

Conversation

@cclauss

@cclauss cclauss commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Fix build warnings like:

warning: ffpyplayer\pic.pxd:21:61: The keyword 'nogil' should appear at the end of the function signature line. Placing it before 'except' or 'noexcept' will be disallowed in a future version of Cython.

% git grep ' nogil '

https://github.com/cython/cython/blob/e2ef20c527c7d0b1b01d2cbb486c0db92d54d323/Cython/Compiler/Parsing.py#L3148-L3151

Includes the fixes from:

@matham
matham merged commit 27614b2 into matham:master Oct 31, 2026
16 checks passed
@matham

matham commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Thanks for the changes and sorry for the long delay. I don't have much time for ffpyplayer these days :(

@cclauss
cclauss deleted the move-nogil-to-end-of-function-signatures branch November 1, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants