Skip to content

Load shared-assets common/v3 #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-matt-hillsdon merged 1 commit into from
Oct 26, 2026
Merged

Load shared-assets common/v3 #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,9 @@
<% if (typeof VITE_FOUNDATION_BUILD !== 'undefined' && VITE_FOUNDATION_BUILD
=== 'true') { %>
<script
src="https://shared-assets.microbit.org/common/v2/common.js"
src="https://shared-assets.microbit.org/common/v3/common.js"
async
></script>
<link
rel="stylesheet"
href="https://shared-assets.microbit.org/common/v2/main.css"
/>
<script>
// GA config itself is via the common assets config depending on consent.
window.dataLayer = window.dataLayer || [];
Expand Down
2 changes: 1 addition & 1 deletion src/compliance/web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { isStageWithAnalytics } from "../logging/stage";

/**
* Surface of the shared-assets `commonConsent` API
* (https://shared-assets.microbit.org/common/v2/common.js) that we depend
* (https://shared-assets.microbit.org/common/v3/common.js) that we depend
* on. Defined here only to give the compliance code a typed handle on
* `window` — the script itself is the authoritative source of behaviour.
*/
Expand Down
Loading