Repository navigation
Fix require() of botframework-webchat-fluent-theme - #5976
Merged
Merged
Conversation
added 2 commits
October 28, 2026 15:24
The "." export used a misspelled "required" condition, so Node.js require(), require.resolve() and TypeScript node16/nodenext in CommonJS could not resolve the package.
Eugene (OEvgeny)
marked this pull request as ready for review
October 28, 2026 23:03
Eugene (OEvgeny)
requested review from
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
October 28, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
require()failing to resolvebotframework-webchat-fluent-theme, in PR #5976, by @OEvgenyDescription
The
"."export ofbotframework-webchat-fluent-themeused a misspelled"required"condition, so CommonJS consumers (Node.jsrequire(), jest without mocks, TypeScriptnode16/nodenextin CommonJS) could not resolve the package. The condition is now"require"; ESMimportand webpack 4 (which readsmain) were not affected and resolve as before.Specific Changes
packages/fluent-theme/package.json:"required"→"require"packages/fluent-theme/src/__tests__/packageExports.spec.js:require()by package name resolves and loads the CommonJS entrypoint.changelog/<PR#>-<slug>.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed