Repository navigation
fix: Support custom tag ordering and null assignment in OpenApiOperation.Tags - #3128
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR brings
OpenApiOperation.Tagsbehavior into parity withOpenApiDocument.Tags(which was updated in #3053 and #3054).Currently,
OpenApiOperation.Tags:null, preventing callers from resetting the tags property to null.new HashSet<OpenApiTagReference>(value, OpenApiTagComparer.Instance)unless it was already aHashSet<OpenApiTagReference>usingOpenApiTagComparer. This discards custom comparers, custom tag orderings (SortedSet<OpenApiTagReference>), andImmutableSortedSet<OpenApiTagReference>.This fix updates the setter to allow
nulland preserves custom comparers,SortedSet, andImmutableSortedSet.Type of Change
Related Issue(s)
Fixes #3115
Changes Made
OpenApiOperation.Tagssetter to reset_tags = nullwhen assignednull.OpenApiOperation.Tagssetter to preserveHashSetinstances with non-default comparers,SortedSet<OpenApiTagReference>, andImmutableSortedSet<OpenApiTagReference>, aligning withOpenApiDocument.Tags.using System.Collections.Immutable;under#if NET.OpenApiOperationTests.csverifying null re-initialization, custom equality comparers, sorted sets, and immutable sorted sets.Testing
Local verification:
dotnet run --project test/Microsoft.OpenApi.Tests/Microsoft.OpenApi.Tests.csproj-> 1304 passed, 0 failed.dotnet run --project test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj-> 635 passed, 0 failed.Checklist
Versions applicability
Additional Notes
cc Vincent Biret (@baywet) for review as this mirrors the previous improvements made to
OpenApiDocument.Tags.