Repository navigation
test: close validators and run regression tests in CI - #469
Open
与世无争剑宇子 (yushiwuzhengjianyuzi) wants to merge 1 commit into
Open
与世无争剑宇子 (yushiwuzhengjianyuzi) wants to merge 1 commit into
与世无争剑宇子 (yushiwuzhengjianyuzi) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
afterEach, including when assertions fail.npm testin the Node.js CI matrix afternpm run build-all.Why
With TypeScript 7, each validator owns a native compiler process. The validator suite created a new instance per test without releasing it, which can exhaust compiler resources on some environments. The CI workflow also only built the workspace, so regressions in the test suite were not enforced.
Validation
npm test— 177 tests passed, 0 failednpm run build-all— passedCloses #463