Repository navigation
Allow caching outputless plugin operations without rush-project.json - #6150
Open
Ian Clanton-Thuon (iclanton) wants to merge 1 commit into
Open
Ian Clanton-Thuon (iclanton) wants to merge 1 commit into
Ian Clanton-Thuon (iclanton) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused eligibility change preserves the required safeguards, includes regression coverage, and has no identified blocking issues.
0 open findings
What changed in this PR
Allows explicitly outputless plugin operations to use Rush’s build cache without rush-project.json, while preserving cache-input, hotlink, and explicit-disable safeguards.
Changes:
- Shares cache eligibility logic between execution and cobuild planning.
- Adds regression tests for eligible operations and required configuration.
- Updates the public API report and change record.
| File | Description |
|---|---|
| libraries/rush-lib/src/logic/operations/test/CacheableOperationPlugin.test.ts | Tests caching without project configuration. |
| libraries/rush-lib/src/logic/operations/CacheableOperationPlugin.ts | Uses shared eligibility logic. |
| libraries/rush-lib/src/logic/operations/BuildPlanPlugin.ts | Supplies operation settings for planning. |
| libraries/rush-lib/src/api/test/RushProjectConfiguration.test.ts | Tests eligibility restrictions and explicit disabling. |
| libraries/rush-lib/src/api/RushProjectConfiguration.ts | Implements and documents outputless-operation eligibility. |
| common/reviews/api/rush-lib.api.md | Records optional eligibility parameters. |
| common/changes/@microsoft/rush/fix-cache-outputless-plugin-operations_2026-10-15-21-41-39.json | Records the caching behavior change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bharat Middha (bmiddha)
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outputFolderNames: []Validation
rushx buildrushx test --test-path-pattern CacheableOperationPlugin.test(37 passed)rushx test --test-path-pattern RushProjectConfiguration.test(30 passed)rushx test --test-path-pattern BuildPlanPlugin.test(1 passed)rush change --verify --no-fetchBroader test note
A full local
rush-librun was attempted. The changed suites passed, while unrelated environment-sensitive tests failed because daemon tests reject the existing user/repository.envconfiguration and a tar signal test returned the platform tar exit code 0 instead of 1.