Repository navigation
[rush-daemon] Stabilize delayed-reply wire test - #6153
Open
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Open
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Conversation
Control pong write completion and the tracker clock instead of relying on socket buffer sizes and a 100 ms wall-clock activity window. Preserve idle and resumed-activity assertions and verify the reply also ages out again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2fdae5a5-bbb9-4f39-a3e0-c0d21203e97a Assistant-model: GPT-6.1 Sol
Arshad Narmawala (anarmawala)
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the timing-sensitive daemon wire test that failed in PR #6096's Node 26 Linux job.
The old test checked a 100 ms activity window after receiving and decoding a large pong. A descheduled client could legitimately miss that window. This replaces socket-buffer assumptions and the real-time sleep with a controlled pong-write gate, explicit server activity barriers, and a controlled monotonic clock. The real socket/handshake and idle/active assertions remain; another assertion verifies that completed-write activity expires too.
No production behavior, retries, timeouts, or test enablement changes.
How it was tested
Expected: true; Received: false) with a 150 ms client pause after decoding a pong.