Not convinced about the disable smart send notification flow #22542

Activity

1. Isidor Nikolic (isidorn)

   assigned

   Anthony Kim (anthonykim1)

   on Nov 28, 2023
2. github-actions

   added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Nov 28, 2023
3. anthonykim1 commented on Dec 8, 2023

   

   Anthony Kim (anthonykim1)

   on Dec 8, 2023

   More actions

   Hi Isidor Nikolic (@isidorn) Thank you for your feedback! When you say better UI that is close to the actual error, do you mean possibly changing color of the "Disable Smart Send" button to red instead of blue?

   Regarding resolution, it is tricky because Python standard library module AST which is behind the Smart Send logic refuses to parse a file with error, deprecated code entirely. This unable us to use smart send in parts of file where there is no error or deprecated code.
4. github-actions

   added

   info-neededIssue requires more information from posterIssue requires more information from poster

   on Dec 8, 2023
5. isidorn commented on Dec 11, 2023

   

   Isidor Nikolic (isidorn)

   on Dec 11, 2023

   Author

   More actions

   Hi Anthony Kim (@anthonykim1)

   do you mean possibly changing color of the "Disable Smart Send" button to red instead of blue?

   No. I meant some UI that is actually a part of the Smart Send flow. If such UI does not exist, should this maybe be a modal dialog? Similarly how errors before starting debugging are modal?

   Also as an extension you can not control the color of the notification buttons (theme defines this).
6. github-actions

   removed

   info-neededIssue requires more information from posterIssue requires more information from poster

   on Dec 11, 2023
7. Anthony Kim (anthonykim1)

   added

   needs proposalNeed to make some design decisionsNeed to make some design decisions

   needs spikeLabel for issues that need investigation before they can be worked on.Label for issues that need investigation before they can be worked on.

   area-repl

   and removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Nov 21, 2024
8. Anthony Kim (anthonykim1)

   added

   needs community feedbackAwaiting community feedbackAwaiting community feedback

   and removed

   needs spikeLabel for issues that need investigation before they can be worked on.Label for issues that need investigation before they can be worked on.

   on Dec 10, 2024
9. github-actions commented on Dec 10, 2024

   

   github-actionsBot

   on Dec 10, 2024 – with GitHub Actions

   More actions

   Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.
10. Karthik Nadig (karthiknadig)

    added

    bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

    on Dec 19, 2024
11. Anthony Kim (anthonykim1)

    removed

    needs community feedbackAwaiting community feedbackAwaiting community feedback

    on Feb 3, 2025
12. anthonykim1 commented on Oct 21, 2026

    

    Anthony Kim (anthonykim1)

    on Oct 21, 2026

    More actions

    Thanks for clarifying the desired interaction. This is covered by #22558, which tracks improving the Smart Send parse-failure warning and providing a way to run the explicit selection or line without disabling Smart Send. Consolidating there while preserving your specific suggestion of in-flow UI or a modal instead of a detached notification.

    Duplicate of #22558

    (generated by Copilot)
13. Anthony Kim (anthonykim1)

    closed this as a duplicateof Smart send warning message feedback #22558 on Oct 21, 2026
14. github-actions

    removed

    needs proposalNeed to make some design decisionsNeed to make some design decisions

    on Oct 21, 2026