Skip to content

⚰️ remove unusable workflow methods - #224

Merged
ianardee merged 1 commit into
mainfrom
kill-v1-workflow
Oct 22, 2026
Merged

ianardee merged 1 commit into
mainfrom
kill-v1-workflow

Conversation

@ianardee

Copy link
Copy Markdown
Collaborator

Description

Remove workflow API removed on the server.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@ianardee ianardee changed the title ⚰️ remove unused workflow methods ⚰️ remove unusable workflow methods Oct 22, 2026
@ianardee
ianardee requested review from sebastianMindee and a balanced review from Copilot October 22, 2026 09:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The bundled workflow execution sample still directs users to the removed method and needs updating or removal.

1 open issue
What changed in this PR

Removes the V1 client’s workflow execution API because the corresponding server API has been retired, while retaining workflow prediction through polling.

Changes:

  • Removes executeWorkflow() and its private request helper.
  • Removes the direct workflow execution functional test while preserving polling tests.
File Description
tests/​V1/​Workflow/​WorkflowTestFunctional.php Removes the obsolete workflow execution test.
src/​V1/​Client.php Removes the public execution method and private request helper.

Review effort: Balanced

Comment thread src/V1/Client.php

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The removals consistently implement the declared breaking change, with no remaining callers or blocking issues identified.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@ianardee
ianardee merged commit 913fc43 into main Oct 22, 2026
32 checks passed
@ianardee
ianardee deleted the kill-v1-workflow branch October 22, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants