Repository navigation
⚰️ remove unusable workflow methods - #224
Merged
Merged
Conversation
ianardee
requested review from
sebastianMindee
and
a balanced review from Copilot
October 22, 2026 09:36
sebastianMindee
approved these changes
Oct 22, 2026
There was a problem hiding this comment.
🟡 Changes recommended
The bundled workflow execution sample still directs users to the removed method and needs updating or removal.
1 open issue
What changed in this PR
Removes the V1 client’s workflow execution API because the corresponding server API has been retired, while retaining workflow prediction through polling.
Changes:
- Removes
executeWorkflow()and its private request helper. - Removes the direct workflow execution functional test while preserving polling tests.
| File | Description |
|---|---|
tests/V1/Workflow/WorkflowTestFunctional.php |
Removes the obsolete workflow execution test. |
src/V1/Client.php |
Removes the public execution method and private request helper. |
Review effort: Balanced
ianardee
force-pushed
the
kill-v1-workflow
branch
from
October 22, 2026 09:41
97596d7 to
9348738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Remove workflow API removed on the server.
Types of changes