Repository navigation
Resolve open code scanning alerts - #3755
Merged
Merged
Conversation
- Reference the shared workflow with the self-repository `$/` syntax (zizmor self-repository) - Move the prettier hook to the maintained rbubley/mirrors-prettier mirror, since pre-commit/mirrors-prettier is archived (zizmor archived-uses) - Make the <script> extraction regex in the docs app test case-insensitive (CodeQL js/bad-tag-filter)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the four open alerts on https://github.com/modelcontextprotocol/python-sdk/security/code-scanning. No linked issue: maintainer housekeeping.
Motivation and Context
zizmor/self-repository(x2): referenceshared.ymlwith the$/self-repository syntax GitHub recommends for same-repo reusable workflows, instead of the workspace-relative./form.zizmor/archived-uses:pre-commit/mirrors-prettieris archived. Move the hook to the maintainedrbubley/mirrors-prettiermirror.js/bad-tag-filter(CodeQL): the<script>extraction regex intests/docs_src/test_apps.test.jsgets theiflag. It only reads a known constant from the example server, but case-insensitivity is the one condition the rule checks for this pattern.How Has This Been Tested?
zizmor .github/workflows .pre-commit-config.yamlno longer reports the two findings.pre-commit run prettier --all-filespasses with the new mirror. Prettier 3.9.10 reports every yaml/json5 file already formatted, so nothing is reformatted.node --test tests/docs_src/test_apps.test.jspasses.Breaking Changes
None.
Types of changes
Checklist
help wanted, or I'm a maintainer)Additional context
The
$/syntax is not available on GitHub Enterprise Server, which doesn't affect this repository.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.