Repository navigation
fix(app): explicitly use ring crypto provider - #8149
Merged
Merged
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
ring crypto providerring crypto provider
aecsocket
approved these changes
Oct 29, 2026
Contributor
|
@Mergifyio queue |
✅ Merged into
|
| Condition | Required by | |
|---|---|---|
| ✅ | github-review-approved |
GitHub branch protection |
The batch, tested in place
| Condition | Required by | |
|---|---|---|
| ✅ | any of: check-success = Lint and Test, check-neutral = Lint and Test, check-skipped = Lint and Test |
GitHub branch protection |
Times in UTC · dashboard · how the merge queue works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because both the
ringandaws_lc_rsfeatures of rustls are now enabled (transitively), unless one crypto provider is explicitly chosen as default, rustls will panic. This luckily isn't an issue with prod app builds because the updater feature bringstauri-plugin-updaterwhich sets a global provider:https://github.com/modrinth/plugins-workspace/blob/0d30f2aa28ec668ce187d527da1c475da3c01cbc/plugins/updater/src/updater.rs#L492-L494
Though it's a pretty weird thing to do for a library. So we are lucky