Skip to content

fix(app): explicitly use ring crypto provider - #8149

Merged
mergify[bot] merged 3 commits into
mainfrom
fetch/fix-crypto-backend
Oct 29, 2026
Merged

mergify[bot] merged 3 commits into
mainfrom
fetch/fix-crypto-backend

Conversation

@fetchfern

@fetchfern fetchfern commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Because both the ring and aws_lc_rs features of rustls are now enabled (transitively), unless one crypto provider is explicitly chosen as default, rustls will panic. This luckily isn't an issue with prod app builds because the updater feature brings tauri-plugin-updater which sets a global provider:

if rustls::crypto::CryptoProvider::get_default().is_none() {
    let _ = rustls::crypto::ring::default_provider().install_default();
}

https://github.com/modrinth/plugins-workspace/blob/0d30f2aa28ec668ce187d527da1c475da3c01cbc/plugins/updater/src/updater.rs#L492-L494

Though it's a pretty weird thing to do for a library. So we are lucky

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@fetchfern fetchfern changed the title fix(app-lib): explicitly use ring crypto provider fix(app): explicitly use ring crypto provider Oct 29, 2026
@aecsocket

Copy link
Copy Markdown
Contributor

@Mergifyio queue

@mergify

mergify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Merged into main as 5e78838 at 11:22 UTC

Less than a minute in the queue, with no time running CI.

So far

  • ✅ Entered the queue Thu 29 Oct, 11:22 · rule default · triggered by @aecsocket with the @mergifyio queue command
  • ⚡ Direct Merge · Draft PR skipped, base moved only in frontend
  • ✅ Merged 11:22 · 5e78838
Merge conditions: 2 of 2 met

This pull request

Condition Required by
✅ github-review-approved GitHub branch protection

The batch, tested in place

Condition Required by
✅ any of: check-success = Lint and Test, check-neutral = Lint and Test, check-skipped = Lint and Test GitHub branch protection

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Oct 29, 2026
@mergify
mergify Bot merged commit 5e78838 into main Oct 29, 2026
16 of 17 checks passed
@mergify
mergify Bot deleted the fetch/fix-crypto-backend branch October 29, 2026 11:22
@mergify mergify Bot removed the queued label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants