Skip to content

fix: mark all prev issues as moderator resolved when submit review on project #8150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Oct 29, 2026
Merged

fix: mark all prev issues as moderator resolved when submit review on project #8150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions apps/frontend/src/providers/project-review/review-decision.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ export async function applyReviewDecision(
onMessageSent: () => void,
): Promise<void> {
const threads = client.labrinth.threads_v3
const approving =
decision.status !== undefined && ['approved', 'unlisted', 'private'].includes(decision.status)
async function updateFacets() {
for (const facet of decision.facetUpdates) {
assertCurrent()
await threads.editIssueFacet(facet.id, facet.data)
}
}
assertCurrent()
if (approving) await updateFacets()
assertCurrent()
// Send thread messages after the status change so they appear below its message in the thread.
if (decision.status) {
Expand Down Expand Up @@ -69,9 +79,6 @@ export async function applyReviewDecision(
throw new ReviewIssuesError('message', error)
}
}
for (const facet of decision.facetUpdates) {
assertCurrent()
await threads.editIssueFacet(facet.id, facet.data)
}
if (!approving) await updateFacets()
assertCurrent()
}
Loading