Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
WorkflowService.StartNexusOperation, a direct Nexus call, with the request and response of temporalio#720 field for field.It leaves out
CancelNexusOperation, since the PoC serves only sync operations.Why?
Native Workflow reads put no Records in History (S105). A Workflow reads its pages through a direct System Nexus call, which creates no caller-side state and no History event. Using the api#720 shape keeps the PoC on Roey's planned RPC.
How did you test it?
buf lint,buf breakingagainst main,api-linterandmake http-api-docs.