Repository navigation
Conversation
A provider hands out handles and producers, and registers once on a client or Worker, so the accessors never pick between two stores silently.
Providers must serialize calls on one producer, and a caller needs to know what to do after a cancelled or unknown append.
The read contract promised every record once, which a resumed read keeps only for stored records. A second producer object for one session is refused, and registering the plugin twice warns.
Core runs the store, so the provider classes become client plugins that name one. Connecting the client connects the store, and every Worker built from that client hands it to Core.
Core asks about owners over the connection that connected the store, so a second connection got the first one's answers. A Worker now needs a client made with Client.connect whatever connected the store first, and the delete test checks a stream that held a record.
moetemp
marked this pull request as draft
October 12, 2026 06:58
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
RedisStreamsandMemoryStreams, the client plugins that name the store Core runs.StreamStorePluginis aSimplePluginthat connects the store inconnect_service_client. Every Worker built from that client hands it to Core asstream_store.RedisStreamstakes URLs and Core's settings. TLS comes from arediss://URL and checks the server against the system roots only.MemoryStreams()is for tests.ValueError, and so does a second store on one client or a second connection on one store.delete_workflow_streams(namespace, workflow_id)goes through Core'sDeleteOwner.Why?
Core runs the store, so the provider classes become configuration (DD-6, DD-90). Core checks a stream's owner over the connection that connected the store, so the store comes from the client.
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_store_plugin.pyruns on the dev server.