Repository navigation
Conversation
1 of 3 tasks
2 of 3 tasks
Owner
Author
|
Combined into #239. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
StreamRecordand the hashes lang takes before Core stores the records.StreamRecord[T],RecordKind,SupersessionandCursorgo intemporalio.contrib.streams._body.pytakes the plaintextcontent_hashand the batch digest, both before the codec. Core stores them unchanged._wire.pyturns a record of Core's read answer into aStreamRecord. A supersession that Core synthesized becomes aSUPERSEDEDrecord.Why?
Only lang has the plaintext. With both hashes taken before the codec, a retry through a codec with a fresh nonce still dedupes (DD-11).
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_records_wire.pyalso checks the digest against the vector Core's tests pin.