Repository navigation
Conversation
2 of 3 tasks
# Conflicts: # temporalio/contrib/streams/__init__.py # temporalio/contrib/streams/_handles.py # tests/contrib/streams/test_outside_handles.py
# Conflicts: # temporalio/contrib/streams/_handles.py
2 of 3 tasks
Owner
Author
|
Combined into #241. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR raises
StreamUnsupportedErrorfor stream owners and readers outside this release.workflow_reader()always raisesStreamUnsupportedError. It lives alone in_workflow.pyfor now.StreamRefof any kind decodes. Opening a handle on a kind other than"workflow"raises, and so doesactivity_handle()in an Activity with no Workflow.Why?
Only Workflow-owned streams ship, and Workflow consumption is out of scope (DD-2). A ref that fails to decode would fail a Workflow Task on every retry when it comes in as input. So the check runs where a handle opens.
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_unsupported_owners.pyandtest_topics_refs.py, on the dev server.