Repository navigation
Conversation
A reader of many Topics of one type had to declare each Topic. subscribe(type=T) decodes the Topics with no type as T, and a typed Topic keeps its own type.
…default-read-type
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
type=tosubscribe()onClientStreamand Activity Streams. Topics with no type decode as that type. A Topic fromtopic(name, type=...)keeps its own type.Why?
A reader of many Topics of one type had to declare each Topic before the read (DECISIONS.md S29).
How did you test it?
pytest tests/contrib/streams/test_facade.py, with the in-memory stand-in for the extension.