Repository navigation
fix: center page loading spinner on test page (@josiahbergen) - #8550
Open
josiahbergen wants to merge 1 commit into
Open
josiahbergen wants to merge 1 commit into
josiahbergen wants to merge 1 commit into
Conversation
AngeloChristian1
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
if the test page is taking a while to load some resource, it will show "Test page is still loading..." along with a small spinner. this message was not centered vertically!
the root cause is because the text's container (
.pageTest) is a1fr auto 1frgrid, and the text gets centered within the top row, not the whole container.this change is a tiny class tweak that makes sure LoadingPage spans the whole thing. I got rid of
h-fullbecause it only made LoadingPage as tall as its grid row, and addingrow-span-fullmakes it redundant.here's a before/after comparison:
before

after

Checks
I couldn't find any pre-existing issues about this, and I used conventional commits + username in the commit message.