Skip to content

fix: center page loading spinner on test page (@josiahbergen) - #8550

Open
josiahbergen wants to merge 1 commit into
monkeytypegame:masterfrom
josiahbergen:fix/center-page-loading-spinner
Open

josiahbergen wants to merge 1 commit into
monkeytypegame:masterfrom
josiahbergen:fix/center-page-loading-spinner

Conversation

@josiahbergen

Copy link
Copy Markdown

Description

if the test page is taking a while to load some resource, it will show "Test page is still loading..." along with a small spinner. this message was not centered vertically!

the root cause is because the text's container (.pageTest) is a 1fr auto 1fr grid, and the text gets centered within the top row, not the whole container.

this change is a tiny class tweak that makes sure LoadingPage spans the whole thing. I got rid of h-full because it only made LoadingPage as tall as its grid row, and adding row-span-full makes it redundant.

here's a before/after comparison:

before
before

after
after

Checks

I couldn't find any pre-existing issues about this, and I used conventional commits + username in the commit message.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 04:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 2, 2026
@github-actions github-actions Bot added the waiting for review Pull requests that require a review before continuing label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants