Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
italian_60k and italian_280k had zero accented words (à è é ì ò ù), while the 7k list has 136. So the big lists were just damaged somewhere along the way, and the site code is fine. I only changed the two JSON files.
Three things were wrong:
I removed the stubs and copies and added the accented words in their alphabetical spots. Everything else is untouched.
For word data I took the accented word forms from Morph-it! and used the LibreOffice Italian dictionary and the FrequencyWords Italian list to check them. I also used the repo's own 7k list as a check and added its accented words. I think the licences are all GPL 3 compatible, but I'm not a lawyer, so tell me if you'd rather I use another source. I also filtered out vulgar verb forms from what I added.
Checks: pnpm check-assets-languages passes, formatting passes, no duplicates, and all 136 accented words from the 7k list are now in both big lists.
Heads up:
Closes #4355