Skip to content

Trim AGENTS.md to rules and conventions - #200

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/lean-agents-md
Oct 28, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/lean-agents-md

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Completes quest/m0/lean-agents-md.md.

AGENTS.md now holds only rules and conventions, in the shape of moq-dev/moq's root AGENTS.md: a one-line pointer to the README, then Required, Guidelines, and Development. The repository description is deleted, not relocated.

Where the deleted guidance went:

  • Site table, URL scheme, setup, deploy commands: already in README.md.
  • run_worker_first and the asset-404 fallback: already commented in sites/*/wrangler.jsonc and sites/lib/worker.ts.
  • Never deploy without permission: stays a Required rule.
  • Upstream fixes go to moq-dev/moq, then bump the moq submodule: stays a Required rule.
  • Bun pin sync: the flake assertion message now names both pins (nixpkgs and packageManager in package.json), so it shows up exactly when CI catches the drift.
  • A watch link never carries ?jwt=: was only in AGENTS.md. Now a comment beside each share-link builder (sites/pub/src/main.ts, src/lib/try.ts).
  • Stack, components, tips, staging hostnames, env files: discoverable from package.json, the code, wrangler.jsonc, and sites/env.d.ts.

The Development section's dev-server line now names just dev, just dev-pub, and just dev-watch, since the old command block is gone. The m0 milestone Goal drops its "agent context is lean" clause now that this lands.

Checks: quest check, just fix (no changes), and just check pass. Comments and docs only, so nothing to look at in the dev server.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 23, 2026 23:17
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the repository description (site table, commands, stack, architecture,
URL scheme, deployment, tips): the README and code comments already cover it.
The Bun pin-sync guidance moves into the flake assertion message, and the
watch-link token rule becomes a comment beside the code that builds the link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 06:24
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1395e0c7-b17c-41e0-bcaa-babf6fc6fbff
Commits

Reviewing files that changed from the base of the PR and between cea4e92 and 979acc7.

Files selected for processing: 6
  • AGENTS.md
  • flake.nix
  • quest/m0/README.md
  • quest/m0/lean-agents-md.md
  • sites/pub/src/main.ts
  • src/lib/try.ts

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d910e48-60fc-4684-90bf-b131f6e11f37
Commits

Reviewing files that changed from the base of the PR and between 47e3e4c and cea4e92.

Files selected for processing: 6
  • AGENTS.md
  • flake.nix
  • quest/m0/README.md
  • quest/m0/lean-agents-md.md
  • sites/pub/src/main.ts
  • src/lib/try.ts
Files with no reviewable changes: 1
  • quest/m0/lean-agents-md.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The changes revise repository guidance, update the Bun version assertion message and quest checklist, and delete a planning document. Comments in the publish and watch page code explain the distinction between publish and subscribe tokens. No runtime behavior changes.

Priority: Low

Merge Risk: Minimal · previous review cea4e

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: reducing AGENTS.md to rules and conventions.
Description check Passed The description directly explains the AGENTS.md changes and related documentation updates.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files. (3 skipped: 3 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
⚔️ Resolve merge conflicts: 💡
  • Resolve merge conflict in branch quest/m0/lean-agents-md
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T06:03:41.642092Z 979acc7 New commits
🔒 Security Review ✅ Completed 2026-10-28T06:04:40.175380Z 979acc7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Merged main twice. The first merge conflicted in AGENTS.md. I kept the trimmed shape and carried over main's one rule change: the quest line now reads "before starting work" instead of "when work mentions a quest". Main made no other edits to the sections this PR removes. Codex reacted 👍 (no findings) on that hand-resolved head, cea4e92.
  • The second merge (979acc7, bringing in moq-dev/moq.dev#199) only touched the quest/m0/README.md link list, and the quest merge driver resolved it without manual edits.
  • quest check --base origin/main passes on 979acc7.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 28, 2026 06:03
@kixelated
kixelated merged commit b76b1e1 into main Oct 28, 2026
3 checks passed
@kixelated
kixelated deleted the quest/m0/lean-agents-md branch October 28, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant