Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Status: implementation done; blocked on moq-dev/moq#6625. CI fails only on the expected Decision for the maintainer: the upstream fix gives qmux (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just checkand CI now type-check the.astrofiles undersrc/with@astrojs/ts-content-mapper:typescriptmoves to^7.1.0-beta(7.1 stable isn't out;latestis 7.0.2), per the quest's decision to adopt the beta now. The caret lets a lockfile refresh pick up 7.1 stable.tsconfig.jsonregisters the mapper undercontentMappers, andcheckpasses--runExternalCode.moq/stays excluded: the only submodule files checked are the onessrc/imports, the same set as before.The existing
.astrofiles surface no errors. I confirmed the mapper is live by injecting a frontmatter type error, a bad expression, a missing Astro prop, and an unknown prop on a Solid island; all four were reported. withastro/astro#18471 doesn't reproduce here onstrict. MDX stays unchecked.Blocked on upstream
TypeScript 7.1's DOM lib types more of
WebTransport, and@moq/qmux'sSession(imported via@moq/watch/@moq/publish) no longer satisfies it:The fix is upstream in moq-dev/moq#6625. With that patch applied to the submodule,
just checkpasses locally. CI here will fail until it merges; then this PR needs a submodule bump, and it stays a draft until then.Verification
just fix, thenjust check(with the upstream patch applied to the submodule): passes,quest checkok.Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code