Repository navigation
!coupon: GMs make Cash Shop coupons (row 205 NX source 2) - #1004
Merged
Merged
Conversation
…op coupon (NX, mesos, items incl. cash ones), with its own code or 16 random characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 205, NX source 2: coupon codes. The Cash Shop already redeemed coupons (0xE6, b072), but the only way to make one was SQL.
!coupon <nx=N|mp=N|np=N|meso=N|item id[xN]>... [days=N] [code=CODE](tier 2, GM). It takes one or more rewards, including cash items, which nothing else in the game gives.code=, the code is 16 random letters and digits, leaving out 0/O/1/I. With nodays=(1–3650), the coupon never expires.WorldAction::MakeCouponis resolved inruntime/src/actor/client/gm.rsbydb::coupon::create. The reply names the code, and the result is logged undergm_audit.Tests:
coupons_take_rewards_an_expiry_and_a_code.coupons_a_gm_makes_are_redeemed: a named code, a duplicate code that is refused, and a random 3-day code. Both redeem with 0x59, and the balances come back as (700, 0, 0) and then (700, 5, 0).gm_commandsandcash_couponspass.