Repository navigation
fitness: wait for the time-up from the GM's /start, not the runner's arrival - #1009
Merged
Merged
Conversation
…art, not from the runner's arrival on stage 1 (until_within)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The master suite's
fitnesstest failed twice on 125ac8b at the "out of stage 1" step.Cause: the test's wait, not the time-up.
untilgives the runner 15 s to be warped out, counted from the runner's arrival on stage 1./start./startand the arrival. Against that come the 100 ms field tick and the warp itself, which can take longer when the suite runs other tests at the same time.The server side is fine.
end_racewarps every occupant who isn't a GM.Change
trace::until_within(c, trace, wait, done)waits for a given time;untilnow calls it with 15 s.fitness.rswaits 30 s.Verification:
fitnesspassed three times in a row on a fresh lane stack, andgm_banpassed alongside it.