Repository navigation
Row 205 S6b: HC /block dialog (Admin/Block, ADMIN_COMMAND 0x04) - #1010
Merged
Merged
Conversation
…img type, as typed; nothing without days or a reason) and its Admin/Block dialog, whose OK sends ADMIN_COMMAND 0x04 {name, reason, days, note}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 205 S6b: HeavenClient's
/blockand its GM dialog (report b176)./block NAME DAYS REASONtakes exactly three words, matched as typed. REASON is looked up case-sensitively among Etc/BlockReason.img'stypevalues (children 1..N, by number). With no days, or a reason that matches none, nothing opens and only the ADMIN_LOG goes (0x52d9ee, 0x52dc30).UIGmBlock) opens. It is centred and modal, and shows the name, a days edit (prefilled), a reason combo (all 13 reasons, preselected) and a short-description edit (focused). Like v83's, it doesn't check what is typed.{04, name, reason (combo index + 1), days, description}, which the server from Row 205 S6: blocking accounts (!ban, !unban, !dc, v83 /ban and /block) #1008 handles. Cancel, the close button and Esc close it. Tab switches between the two edits.Verified:
gm_command_tests(build-dbg) passes. GUI against the lane stack:/block Storyb 3 ADwith a note blocked the account (DB ban_reason 3, ban_until about +3 days), and the client printed "You have successfully blocked access."/block Storyb 7 botopened nothing./block Storyb 7 BOTfollowed by Esc closed the dialog with nothing blocked.