Repository navigation
Row 205 S5a: a hidden GM shows only to GMs - #1011
Merged
Merged
Conversation
…cts, buffs, pets, summons, room balloons) show only to GMs, as v83 drops what is about a character it doesn't know; summons go and come back with the hide; FieldRequest::BroadcastAll for the map's own packets (notices, OX, the jukebox's song); HC drops chat from an unknown character (report b177 R1-R4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 205 S5a (report b177 R1-R4): a hidden GM is absent for those who aren't GMs.
v83's user pool drops every 0xA2..0xCC packet whose character id it doesn't know (FUN_00972401, FUN_009724f9), so the field now sends packets about a hidden GM only to those who see them (
sees: not hidden, or the viewer is a GM).FieldActor::broadcast_by/broadcast_seen_by/broadcast_about: chat, moves, attacks, chairs, effects, buffs, pets, summons, MP eater, beholder and mini-room balloons go only to GMs while the sender hides.FieldRequest::BroadcastAllfor packets about the map, which everyone still sees:/h 2-scope notices, the OX wrong answer, a jukebox's song. The magnet pull also goes to everyone, since it is about the mob.ChatReceivedHandlerdrops chat from a character the stage doesn't know, as v83 does.!hide).Mob control, damage (R5) and directory lookups (R6) follow in S5b.
Tests: runtime and net lib tests with skill data (
what_a_hidden_gm_does_shows_only_to_gms), the full harness suite (305/305), and gm_skills (the stranger doesn't hear a hidden GM) plus jukebox on the final commit.