Repository navigation
[stable34] perf(LogIterator): Read long lines in linear time - #2329
Merged
Merged
Conversation
DerDreschner
force-pushed
the
backport/2327/stable34
branch
from
October 19, 2026 14:24
3b72ba4 to
9c4a9b4
Compare
DerDreschner
marked this pull request as ready for review
October 19, 2026 14:24
DerDreschner
approved these changes
Oct 19, 2026
DerDreschner
enabled auto-merge
October 19, 2026 14:25
LogIterator reads the log backwards in chunks of 8 KB. When a line spans several chunks, every chunk is prepended to the whole buffer before the whole buffer is searched for a newline again. Reading a line of length L therefore takes O(L虏) time. Such long lines can be written, for example by occ upgrade, which forces the debug log level. A log with a few of them stalls the "Errors in the log" setup check and the log viewer. Remember where the line ends, only search the newly read chunk for its start, and then read the whole line at once. This reduces the time to O(L). Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
backport/2327/stable34
branch
from
October 19, 2026 14:30
9c4a9b4 to
c57f714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2327
Warning, This backport's changes differ from the original and might be incomplete鈿狅笍
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.